Skip to content

performance improvements to np.full and np.ones #7682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sklam merged 2 commits into from
Jan 21, 2022
Merged

performance improvements to np.full and np.ones #7682

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1dc133
performance improvements to np.full and np.ones
Dec 21, 2021
540c910
use range(len()) instead of enumerate
Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 24 additions & 16 deletions numba/np/arrayobj.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3789,8 +3789,9 @@ def numpy_full_nd(context, builder, sig, args):

def full(shape, value):
arr = np.empty(shape, type(value))
for idx in np.ndindex(arr.shape):
arr[idx] = value
arr_flat = arr.flat
for idx in range(len(arr_flat)):
arr_flat[idx] = value
return arr

res = context.compile_internal(builder, full, sig, args)
Expand All @@ -3803,8 +3804,9 @@ def numpy_full_dtype_nd(context, builder, sig, args):

def full(shape, value, dtype):
arr = np.empty(shape, dtype)
for idx in np.ndindex(arr.shape):
arr[idx] = value
arr_flat = arr.flat
for idx in range(len(arr_flat)):
arr_flat[idx] = value
return arr

res = context.compile_internal(builder, full, sig, args)
Expand All @@ -3816,8 +3818,9 @@ def numpy_full_like_nd(context, builder, sig, args):

def full_like(arr, value):
arr = np.empty_like(arr)
for idx in np.ndindex(arr.shape):
arr[idx] = value
arr_flat = arr.flat
for idx in range(len(arr_flat)):
arr_flat[idx] = value
return arr

res = context.compile_internal(builder, full_like, sig, args)
Expand All @@ -3830,8 +3833,9 @@ def numpy_full_like_nd_type_spec(context, builder, sig, args):

def full_like(arr, value, dtype):
arr = np.empty_like(arr, dtype)
for idx in np.ndindex(arr.shape):
arr[idx] = value
arr_flat = arr.flat
for idx in range(len(arr_flat)):
arr_flat[idx] = value
return arr

res = context.compile_internal(builder, full_like, sig, args)
Expand All @@ -3843,8 +3847,9 @@ def numpy_ones_nd(context, builder, sig, args):

def ones(shape):
arr = np.empty(shape)
for idx in np.ndindex(arr.shape):
arr[idx] = 1
arr_flat = arr.flat
for idx in range(len(arr_flat)):
arr_flat[idx] = 1
return arr

valty = sig.return_type.dtype
Expand All @@ -3859,8 +3864,9 @@ def numpy_ones_dtype_nd(context, builder, sig, args):

def ones(shape, dtype):
arr = np.empty(shape, dtype)
for idx in np.ndindex(arr.shape):
arr[idx] = 1
arr_flat = arr.flat
for idx in range(len(arr_flat)):
arr_flat[idx] = 1
return arr

res = context.compile_internal(builder, ones, sig, args)
Expand All @@ -3872,8 +3878,9 @@ def numpy_ones_like_nd(context, builder, sig, args):

def ones_like(arr):
arr = np.empty_like(arr)
for idx in np.ndindex(arr.shape):
arr[idx] = 1
arr_flat = arr.flat
for idx in range(len(arr_flat)):
arr_flat[idx] = 1
return arr

res = context.compile_internal(builder, ones_like, sig, args)
Expand All @@ -3886,8 +3893,9 @@ def numpy_ones_like_dtype_nd(context, builder, sig, args):

def ones_like(arr, dtype):
arr = np.empty_like(arr, dtype)
for idx in np.ndindex(arr.shape):
arr[idx] = 1
arr_flat = arr.flat
for idx in range(len(arr_flat)):
arr_flat[idx] = 1
return arr

res = context.compile_internal(builder, ones_like, sig, args)
Expand Down