Skip to content

Make numba.types.Optional __str__ less verbose. - #7583

Merged
sklam merged 1 commit into
numba:masterfrom
stuartarchibald:wip/less_verbose_optional_str
Nov 19, 2021
Merged

Make numba.types.Optional __str__ less verbose.#7583
sklam merged 1 commit into
numba:masterfrom
stuartarchibald:wip/less_verbose_optional_str

Conversation

@stuartarchibald

@stuartarchibald stuartarchibald commented Nov 19, 2021

Copy link
Copy Markdown
Contributor

As title. Whilst well intentioned, the verbose string repr makes
it harder to debug issues with Optional types.

@stuartarchibald
Make numba.types.Optional __str__ less verbose.
ef661c4 
As title. Whilst well intentioned, the verbose string repr makes
it harder to debug issues with Optional types.
@stuartarchibald

stuartarchibald commented Nov 19, 2021

Copy link
Copy Markdown
Contributor Author

Impact on the representation is as follows:
Without this patch:

$ python -c 'from numba import types; print(types.Optional(types.float64))'
OptionalType(float64) i.e. the type 'float64 or None'

With this patch:

$ python -c 'from numba import types; print(types.Optional(types.float64))'
OptionalType(float64)

@stuartarchibald stuartarchibald added this to the Numba 0.55 RC milestone Nov 19, 2021
sklam
sklam approved these changes Nov 19, 2021
View reviewed changes

@sklam sklam left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stuartarchibald stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge and removed 3 - Ready for Review labels Nov 19, 2021
@sklam
sklam merged commit 8215dff into numba:master Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sklam sklam sklam approved these changes
@esc esc Awaiting requested review from esc

Assignees

No one assigned

Labels

5 - Ready to merge Review and testing done, is ready to merge Effort - short Short size effort needed

Projects

None yet

Milestone

Numba 0.55 RC

Development

Successfully merging this pull request may close these issues.

2 participants

@stuartarchibald @sklam