Skip to content

Fixup cuda debuginfo emission for 7177 - #7514

Merged
sklam merged 4 commits into
numba:masterfrom
sklam:enh/fixup_cuda_7177
Oct 27, 2021
Merged

Fixup cuda debuginfo emission for 7177#7514
sklam merged 4 commits into
numba:masterfrom
sklam:enh/fixup_cuda_7177

Conversation

@sklam

@sklam sklam commented Oct 26, 2021

Copy link
Copy Markdown
Member

Based on #7177

@sklam
Fixup for NvvmDIBuilder
d8ef5b1 
- Avoid using fndesc in DIBuilder.mark_subprogram
- Update CUDA target to use the new DIBuilder interface.
@sklam
sklam marked this pull request as ready for review October 27, 2021 00:12
@sklam

sklam commented Oct 27, 2021

Copy link
Copy Markdown
Member Author

BFID numba_smoketest_cuda_yaml_100

@sklam sklam added 3 - Ready for Review CUDA CUDA related issue/PR Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm labels Oct 27, 2021
@sklam

sklam commented Oct 27, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

Build farm failed

sample failed tests:

ERROR: test_user_exception (numba.cuda.tests.cudapy.test_userexc.TestUserExc)
ERROR: test_lineinfo_in_asm (numba.cuda.tests.cudapy.test_lineinfo.TestCudaLineInfo)
ERROR: test_divf_exception (numba.cuda.tests.cudapy.test_fastmath.TestFastMathOption)

(more failed test with the same error)

File "/opt/conda/envs/testenv_7a44fa25-1347-4974-9bb4-10ef57da9c2d/lib/python3.9/site-packages/numba/core/debuginfo.py", line 496, in mark_subprogram
[2021-10-27 00:21:17,346] {docker_operator.py:265} INFO - self._add_subprogram(name=qualname, linkagename=function.name,
[2021-10-27 00:21:17,346] {docker_operator.py:265} INFO - TypeError: _add_subprogram() missing 2 required positional arguments: 'function' and 'argmap'

Looks like I missed a few callsites.

The common thing is cuda10 and cuda9 that are failing. Cuda11 is fine.

@gmarkall

gmarkall commented Oct 27, 2021

Copy link
Copy Markdown
Member

It was brought to my attention that there are some messages from cuobjdump when using this patch, e.g.:

Thread 1 "python" hit Breakpoint 1, __main__::f_241[abi:c4YlEg14BNmCIhjoQbSwRhKGRCuSAGpUwSSQrLKtVgebr26lAJFUB7kWZBtQBBpO6jAvIwkBtQN5BrWaAA_3d_3d](Array<long long, 1, C, mutable, aligned>) () at repro.py:7
7	    i = cuda.grid(1)
(cuda-gdb) next
cuobjdump warning : Function listed in --function 'f' not found
cuobjdump warning : Function listed in --function 'f' not found
cuobjdump warning : Function listed in --function 'f' not found
cuobjdump warning : Function listed in --function 'f' not found

However, this is not a regression - in fact this message appears far fewer times with this PR than without it. So, 👍 😄 .

@sklam

sklam commented Oct 27, 2021

Copy link
Copy Markdown
Member Author

However, this is not a regression - in fact this message appears far fewer times with this PR than without it. So, 👍 😄 .

Good to kn

@sklam sklam added BuildFarm Passed For PRs that have been through the buildfarm and passed and removed Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm labels Oct 27, 2021
@sklam

sklam commented Oct 27, 2021

Copy link
Copy Markdown
Member Author

I got build farm passing now

stuartarchibald
stuartarchibald approved these changes Oct 27, 2021
View reviewed changes

@stuartarchibald stuartarchibald left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. The changes look good on inspection and I've tested manually on CUDA 11.5. That the build farm was failing testing and is now passing suggests the changes are appropriate for the internal API alterations. Thanks again!

@stuartarchibald stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge and removed 3 - Ready for Review labels Oct 27, 2021
@stuartarchibald stuartarchibald added this to the Numba 0.55 RC milestone Oct 27, 2021
@sklam
sklam merged commit 95e7852 into numba:master Oct 27, 2021
@sklam
sklam deleted the enh/fixup_cuda_7177 branch October 27, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartarchibald stuartarchibald stuartarchibald approved these changes
@esc esc Awaiting requested review from esc
@gmarkall gmarkall Awaiting requested review from gmarkall

Assignees

No one assigned

Labels

5 - Ready to merge Review and testing done, is ready to merge BuildFarm Passed For PRs that have been through the buildfarm and passed CUDA CUDA related issue/PR

Projects

None yet

Milestone

Numba 0.55 RC

Development

Successfully merging this pull request may close these issues.

3 participants

@sklam @gmarkall @stuartarchibald