Repository navigation
Fixed outgoing link to nvidia documentation. - #7484
Merged
Merged
Conversation
DhruvPatel01
requested review from
esc,
sklam and
stuartarchibald
as code owners
October 14, 2021 09:21
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch. Suggest using https otherwise looks good.
Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
Contributor
|
Doc now renders with valid link: https://numba--7484.org.readthedocs.build/en/7484/cuda-reference/host.html#profiling |
stuartarchibald
approved these changes
Oct 14, 2021
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch!
stuartarchibald
added
5 - Ready to merge
Contributor
|
@DhruvPatel01 Congratulations on your first contribution to Numba! |
Contributor
Author
|
@stuartarchibald Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier
http://part was missing, so the link was assumed to be relative and was giving 404 error.