Repository navigation
CUDA: Print format string and warn for > 32 print() args - #7479
Merged
Merged
Conversation
CUDA vprintf prints garbage for arguments past the 32nd (a similar limitation on `printf` is outlined in the CUDA C++ Programming Guide at https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#limitations). This commit matches the C/C++ behavior in Python by emitting the format string when more than 32 arguments are provided, instead of printing garbage results. A warning is also produced to explain the behavior that users will see.
gmarkall
added
3 - Ready for Review
CUDA
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch. Couple of minor things to resolve else looks good.
stuartarchibald
added
4 - Waiting on author
Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
Member
Author
|
@stuartarchibald Many thanks for the review - suggestions applied. |
gmarkall
added
4 - Waiting on reviewer
stuartarchibald
approved these changes
Oct 13, 2021
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch and fixes.
stuartarchibald
added
4 - Waiting on CI
Member
Author
|
gpuci run tests |
Member
|
BFID |
Member
|
build farm passed |
sklam
approved these changes
Nov 2, 2021
sklam
added
5 - Ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CUDA vprintf prints garbage for arguments past the 32nd (a similar limitation on
printfis outlined in the CUDA C++ Programming Guide at https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#limitations).This commit matches the C/C++ behavior in Python by emitting the format string when more than 32 arguments are provided, instead of printing garbage results. A warning is also produced to explain the behavior that users will see.