Repository navigation
Fix unicode operator.eq handling of Optional types. - #7477
Merged
Merged
Conversation
As title. This makes it such that the unicode `operator.eq` implementation checks for Optional types and handles them at runtime if they are present. Fixes numba#7474
stuartarchibald
added
3 - Ready for Review
Effort - short
sklam
approved these changes
Oct 11, 2021
sklam
left a comment
sklam
left a comment
Member
There was a problem hiding this comment.
LGTM.
Details: I tried to come up with a simpler solution but I couldn't. To do so, we will need to implement some utils around optional, possibly some intrinsic to unwrapping optional at runtime.
sklam
added
5 - Ready to merge
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title. This makes it such that the unicode
operator.eqimplementation checks for Optional types and handles them at
runtime if they are present.
Fixes #7474