Repository navigation
CUDA: Provide stream in async_done result - #7453
Merged
Merged
Conversation
It's awkward to await on a `Stream.async_done()` for the purpose of enqueuing something new onto the stream, because there is no way to tell which stream finished from the completed future - this forces the user to maintain a mapping between futures and streams. This commit makes the result of the future be the stream on which operations completed, so that the user can obtain the stream from the completed future.
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch, couple of minor things to look at else looks good. This new capability will be useful for e.g. data streams with non-uniform workloads.
stuartarchibald
added
4 - Waiting on author
Update numba/cuda/tests/cudadrv/test_streams.py Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
gmarkall
added
4 - Waiting on reviewer
stuartarchibald
approved these changes
Oct 5, 2021
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch!
stuartarchibald
added
4 - Waiting on CI
Contributor
|
Buildfarm ID: |
stuartarchibald
removed
Pending BuildFarm
Contributor
Passed. |
stuartarchibald
added
5 - Ready to merge
|
This is great, thank you @gmarkall, really useful for streams with non-uniform workloads, as @stuartarchibald said, such as the satellite data feeds I work with. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's awkward to await on a
Stream.async_done()for the purpose of enqueuing something new onto the stream, because there is no way to tell which stream finished from the completed future - this forces the user to maintain a mapping between futures and streams.This PR makes the result of the future be the stream on which operations completed, so that the user can obtain the stream from the completed future.