Repository navigation
Fix #7394 and #6550 & Added test & improved error message - #7395
Merged
Merged
Conversation
also renames range_iter_len -> comprehension_iter_len
MegaIng
requested review from
esc,
sklam and
stuartarchibald
as code owners
September 10, 2021 13:16
Contributor
|
Thanks for the patch @MegaIng. As this contains my patch from #7394 (comment) please could one of you take a look at this @esc @sklam @gmarkall ? Thanks! |
Contributor
@MegaIng RE: the above, I've left some comments here on the original issue: #7394 (comment) |
stuartarchibald
added
3 - Ready for Review
Effort - short
sklam
added
4 - Waiting on author
stuartarchibald
added
4 - Waiting on reviewer
| stmts.append(_new_definition(func_ir, len_func_var, | ||
| ir.Global('range_iter_len', range_iter_len, loc=loc), | ||
| loc)) | ||
| ir.Global('length_of_iterator', |
Contributor
There was a problem hiding this comment.
I'm happy with this choice of name, thanks for altering it!
stuartarchibald
added
4 - Waiting on author
Contributor
|
@sklam please could you re-check? This looks good to me but also contains code I wrote. Thanks. |
stuartarchibald
added
4 - Waiting on reviewer
sklam
added
5 - Ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also renames
range_iter_len->comprehension_iter_lenAs discussed with @stuartarchibald, this adds the code he suggest in both the issues to (the renamed)
comprehension_iter_lenand gives a better error message. It might be worth considering to movecomprehension_iter_lento another module, since it is now even less tightly coupled to therangeobj.