Skip to content

skip azure pipeline test if file not present - #7393

Merged
sklam merged 1 commit into
numba:masterfrom
esc:skip_azure_if_file_missing
Sep 10, 2021
Merged

sklam merged 1 commit into
numba:masterfrom
esc:skip_azure_if_file_missing

Conversation

@esc

@esc esc commented Sep 9, 2021

Copy link
Copy Markdown
Member

This test must not be executed if the azure config is not present, for
example in shipped conda packages or pypi source distributions or
wheels.

 zsh» python -m numba.runtests numba.tests.test_runtests.TestCase.test_azure_config
.
----------------------------------------------------------------------
Ran 1 test in 0.018s

OK
zsh» rm -rf azure-pipelines.yml
zsh» python -m numba.runtests numba.tests.test_runtests.TestCase.test_azure_config
s
----------------------------------------------------------------------
Ran 1 test in 0.000s

OK (skipped=1)

Reference an existing issue

#7392

This test must not be executed if the azure config is not present, for
example in shipped conda packages or pypi source distributions or
wheels.

```
 zsh» python -m numba.runtests numba.tests.test_runtests.TestCase.test_azure_config
.
----------------------------------------------------------------------
Ran 1 test in 0.018s

OK
zsh» rm -rf azure-pipelines.yml
zsh» python -m numba.runtests numba.tests.test_runtests.TestCase.test_azure_config
s
----------------------------------------------------------------------
Ran 1 test in 0.000s

OK (skipped=1)
@esc esc added 3 - Ready for Review Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm labels Sep 9, 2021
@esc esc added this to the Numba 0.54.1 milestone Sep 9, 2021
@esc

esc commented Sep 9, 2021

Copy link
Copy Markdown
Member Author

BFID: numba_smoketest_cpu_yaml_44

@stuartarchibald

Copy link
Copy Markdown
Contributor

BFID: numba_smoketest_cpu_yaml_44

Status?

@stuartarchibald stuartarchibald left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch.

@stuartarchibald stuartarchibald added 4 - Waiting on CI Review etc done, waiting for CI to finish and removed 3 - Ready for Review labels Sep 10, 2021
@esc

esc commented Sep 10, 2021

Copy link
Copy Markdown
Member Author

BFID: numba_smoketest_cpu_yaml_44

Status?

The status was, that all the errors related to this disappeared and the issues probably resolved by #7386 start to manifest.

@stuartarchibald

Copy link
Copy Markdown
Contributor

BFID: numba_smoketest_cpu_yaml_44

Status?

The status was, that all the errors related to this disappeared and the issues probably resolved by #7386 start to manifest.

Thanks for confirming. Patch approved.

@stuartarchibald stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge Effort - short Short size effort needed and removed Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm 4 - Waiting on CI Review etc done, waiting for CI to finish labels Sep 10, 2021
@sklam
sklam merged commit 6c01bbc into numba:master Sep 10, 2021
sklam added a commit to sklam/numba that referenced this pull request Sep 22, 2021
skip azure pipeline test if file not present
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to merge Review and testing done, is ready to merge Effort - short Short size effort needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants