Skip to content

Patch cloudpickle to not reset dynamic class each time it is unpickled #7388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sklam merged 7 commits into from
Sep 21, 2021
Merged

Patch cloudpickle to not reset dynamic class each time it is unpickled #7388

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4d9919c
Add test for dynamic class being reset on unpickle
sklam Sep 8, 2021
1713180
Fix #7356. Dynamic class is being reset everytime it is unpickled.
sklam Sep 8, 2021
ecff457
Add test specific to __main__ module
sklam Sep 8, 2021
e36a44e
Add test for remote process
sklam Sep 8, 2021
e708424
Fix CI.
sklam Sep 8, 2021
6a25ed7
Apply suggestions from code review
sklam Sep 20, 2021
8f6ffdc
Add test from #7356
sklam Sep 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test for remote process
  • Loading branch information
@sklam
sklam committed Sep 8, 2021
commit e36a44e0853898899bd08a43f25227d273130bec
46 changes: 38 additions & 8 deletions numba/tests/test_serialize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import subprocess
import sys
import unittest
from multiprocessing import get_context

from numba.core.errors import TypingError
from numba.tests.support import TestCase
Expand Down Expand Up @@ -234,14 +235,27 @@ def check():
@unittest.skipIf(__name__ == "__main__",
"Test cannot run as when module is __main__")
def test_main_class_reset_on_unpickle(self):
from multiprocessing import get_context

mp = get_context('spawn')
proc = mp.Process(target=check_main_class_reset_on_unpickle)
proc.start()
proc.join(timeout=10)
self.assertEqual(proc.exitcode, 0)

def test_dynamic_class_reset_on_unpickle_new_proc(self):
# a dynamic class
class Klass:
classvar = None

# serialize Klass in this process
saved = dumps(Klass)

# Check the reset problem in a new process
mp = get_context('spawn')
proc = mp.Process(target=check_unpickle_dyn_class_new_proc, args=(saved,))
proc.start()
proc.join(timeout=10)
self.assertEqual(proc.exitcode, 0)


def check_main_class_reset_on_unpickle():
# Load module and get its global dictionary
Expand All @@ -252,21 +266,37 @@ def check_main_class_reset_on_unpickle():
# Get the Klass and check it is from __main__
Klass = glbs['Klass']
assert Klass.__module__ == "__main__"
assert Klass.classvar != 100
saved = dumps(Klass)
# mutate
Klass.classvar = 100
# check
_check_dyn_class(Klass, saved)


def mutator():
Klass.classvar = 100
def check_unpickle_dyn_class_new_proc(saved):
Klass = loads(saved)
assert Klass.classvar != 100
# mutate
Klass.classvar = 100
# check
_check_dyn_class(Klass, saved)


def _check_dyn_class(Klass, saved):
def check():
if Klass.classvar != 100:
raise AssertionError("Check failed. Klass reset.")

saved = dumps(Klass)
mutator()
check()
loads(saved)
loaded = loads(saved)
if loaded is not Klass:
raise AssertionError("Expected reuse")
# Without the patch, each `loads(saved)` will reset `Klass.classvar`
check()
loads(saved)
loaded = loads(saved)
if loaded is not Klass:
raise AssertionError("Expected reuse")
check()


Expand Down