Skip to content

Ensure the NRT is initialized prior to use in external NRT tests. #7386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sklam merged 3 commits into from
Sep 16, 2021
Merged

Ensure the NRT is initialized prior to use in external NRT tests. #7386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8590a74
Ensure the NRT is initialized prior to use in external NRT tests.
stuartarchibald Sep 8, 2021
dd1a0de
Respond to feedback
stuartarchibald Sep 10, 2021
0a04805
Flake8 fix
stuartarchibald Sep 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions docs/source/developer/numba-runtime.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,18 @@ Here is an example that uses the ``nrt_external.h``:
return mi;
}

It is important to ensure that the NRT is initialized prior to making calls to
it, calling ``numba.core.runtime.nrt.rtsys.initialize(context)`` from Python
will have the desired effect. Similarly the code snippet:

.. code-block:: Python

from numba.core.registry import cpu_target # Get the CPU target singleton
cpu_target.target_context # Access the target_context property to initialize

will achieve the same specifically for Numba's CPU target (the default). Failure
to initialize the NRT will result in access violations as function pointers for
various internal atomic operations will be missing in the ``NRT_MemSys`` struct.

Future Plan
===========
Expand Down
10 changes: 7 additions & 3 deletions numba/tests/test_nrt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import numpy as np

from numba import njit
from numba.core import typing, types
from numba.core import types
from numba.core.compiler import compile_isolated, Flags
from numba.core.runtime import (
rtsys,
Expand All @@ -25,7 +25,7 @@

from numba.tests.support import (MemoryLeakMixin, TestCase, temp_directory,
import_dynamic)
from numba.core import cpu
from numba.core.registry import cpu_target
import unittest

enable_nrt_flags = Flags()
Expand Down Expand Up @@ -82,7 +82,7 @@ def setUp(self):
# Reset the Dummy class
Dummy.alive = 0
# initialize the NRT (in case the tests are run in isolation)
cpu.CPUContext(typing.Context())
cpu_target.target_context

def test_meminfo_refct_1(self):
d = Dummy()
Expand Down Expand Up @@ -554,6 +554,10 @@ def foo(x):
class TestNrtExternalCFFI(MemoryLeakMixin, TestCase):
"""Testing the use of externally compiled C code that use NRT
"""
def setUp(self):
# initialize the NRT (in case the tests are run in isolation)
super(TestNrtExternalCFFI, self).setUp()
cpu_target.target_context

def compile_cffi_module(self, name, source, cdef):
from cffi import FFI
Expand Down