Skip to content

Allow arbitrary walk-back in reduction nodes to find inplace_binop. #7349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sklam merged 5 commits into from
Sep 10, 2021
Merged

Allow arbitrary walk-back in reduction nodes to find inplace_binop. #7349

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
77f4949
Walk backwards through var1=var2 assignments in reduction nodes until…
DrTodd13 Aug 26, 2021
c0d087b
Add test for issue7344.
DrTodd13 Aug 26, 2021
3b30a96
Fix typo.
DrTodd13 Aug 26, 2021
3077a51
Just take the last ir.Expr from reduction nodes.
DrTodd13 Aug 31, 2021
eeac2fa
Add second test for issue 7344 where one of the reduction variables i…
DrTodd13 Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add second test for issue 7344 where one of the reduction variables i… 
…s only incremented in the if part of an if/else.
  • Loading branch information
@DrTodd13
DrTodd13 committed Aug 31, 2021
commit eeac2fa39107da8c8457e5003445785bcddaccd0
14 changes: 14 additions & 0 deletions numba/tests/test_parfors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1574,6 +1574,20 @@ def test_impl(A, cond):
return s
self.check(test_impl, np.ones(10), np.ones(10).astype('bool'))

def test_if_not_else_reduction(self):
# issue #7344
def test_impl(A, cond):
s = 1
t = 10
for i in prange(A.shape[0]):
if cond[i]:
s += 1
t += 1
else:
s += 2
return s + t
self.check(test_impl, np.ones(10), np.ones(10).astype('bool'))

def test_two_d_array_reduction_reuse(self):
def test_impl(n):
shp = (13, 17)
Expand Down