Repository navigation
Update MapConstraint to handle type coercion for typed.Dict correctly. - #7309
Merged
Merged
Conversation
As title. `typed.Dict` takes its type from the first element so coercion must be done against the type of that element. Further only "safe" conversions are permitted as per the typed.Dict impl, everything else compatible is typed as a LiteralStrKeyDict. Fixes numba#6420.
stuartarchibald
added
3 - Ready for Review
Effort - short
sklam
added
5 - Ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title.
typed.Dicttakes its type from the first element socoercion must be done against the type of that element. Further only
"safe" conversions are permitted as per the typed.Dict impl,
everything else compatible is typed as a LiteralStrKeyDict.
Fixes #6420.