Repository navigation
CUDA: Skip multi-GPU copy test with peer access disabled - #7266
Merged
Merged
Conversation
When peer access is disabled (e.g. with one GPU in WDDM mode and one in TCC mode), a device-to-device copy between the two fails, causing `TestMultiGPUContext.test_with_context` to fail. We fix this issue by moving the test of device-to-device copy into its own test method, which is skipped when peer access is disabled. Fixes numba#7253.
gmarkall
added
2 - In Progress
CUDA
stuartarchibald
approved these changes
Aug 3, 2021
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch, looks good.
stuartarchibald
added
4 - Waiting on CI
Contributor
|
Buildfarm ID: |
Contributor
Passed. Test system has 2x GPUs according to nvidia-smi. |
stuartarchibald
added
5 - Ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When peer access is disabled (e.g. with one GPU in WDDM mode and one in TCC mode), a device-to-device copy between the two fails, causing
TestMultiGPUContext.test_with_contextto fail. We fix this issue by moving the test of device-to-device copy into its own test method, which is skipped when peer access is disabled.Fixes #7253.