Repository navigation
Use normal list constructor in List.__new__() - #7257
Merged
Merged
Conversation
Calling `list.__new__()` without arguments and then `list.__init__()` with arguments on the resulting object is not guaranteed to work - the fact that `list.__new__()` doesn't refer to its arguments (and therefore doesn't strictly require them to be the same as the arguments to `__init__()`) is an implementation detail. It is safer to just call `list(*args, **kwargs)` instead.
eric-wieser
approved these changes
Jul 28, 2021
esc
approved these changes
Jul 28, 2021
esc
left a comment
esc
left a comment
Member
There was a problem hiding this comment.
thank you for the patch @gmarkall -- thank you for the review @eric-wieser !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
list.__new__()without arguments and thenlist.__init__()with arguments on the resulting object is not guaranteed to work - the fact thatlist.__new__()doesn't refer to its arguments (and therefore doesn't strictly require them to be the same as the arguments to__init__()) is an implementation detail.It is safer to just call
list(*args, **kwargs)instead.With thanks to @eric-wieser (ref: #7251 (comment))