Skip to content

replace wordings of WIP by draft PR - #7235

Merged
sklam merged 2 commits into
numba:masterfrom
ickc:contri-wording
Jul 23, 2021
Merged

sklam merged 2 commits into
numba:masterfrom
ickc:contri-wording

Conversation

@ickc

@ickc ickc commented Jul 22, 2021

Copy link
Copy Markdown
Contributor

Improve this pull request template by mentioning draft PR.

@ickc

ickc commented Jul 22, 2021

Copy link
Copy Markdown
Contributor Author

Based on the automatic message from @esc in another PR it seems it is parsing the [WIP] label so may be this PR itself is not self-contained.

@esc

esc commented Jul 22, 2021

Copy link
Copy Markdown
Member

Based on the automatic message from @esc in another PR it seems it is parsing the [WIP] label so may be this PR itself is not self-contained.

I am (still) human, but I do want to become an AI at some point by transferring my consciousness into a computer -- so thank you for assuming I am a bot, it confirms that I may be part of the way there already!!!

Jokes aside, I'll mark this as a feature request also. Do you want it to be ready for review also?

@esc esc added feature_request Effort - short Short size effort needed and removed feature_request labels Jul 22, 2021
@esc

esc commented Jul 22, 2021

Copy link
Copy Markdown
Member

Jokes aside, I'll mark this as a feature request also. Do you want it to be ready for review also?

Sorry, I meant "review effort -short".

@ickc

ickc commented Jul 22, 2021

Copy link
Copy Markdown
Contributor Author

Ha! I thought you wrote a bot using your API keys showing you as the author...

It's a very minor wording change so it's ready to review. Feel free to reject it though if you think the current one is fine.

@esc

esc commented Jul 22, 2021

Copy link
Copy Markdown
Member

Ha! I thought you wrote a bot using your API keys showing you as the author...

I should totally do that and call it "Augmented Intelligence" I'll get it learn from all my comments on github and it will generate responses in my communication style!

It's a very minor wording change so it's ready to review. Feel free to reject it though if you think the current one is fine.

OK.

@esc

esc commented Jul 22, 2021

Copy link
Copy Markdown
Member

It's a very minor wording change so it's ready to review. Feel free to reject it though if you think the current one is fine.

I think it is valid, we are adopting the builtin WIP feature more and more, we should encourage folks to use it! Thank you for the patch!

@esc esc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartarchibald there are some finer grammatical points in this PR that require an english native speaker, can you take a look please? Thank you!

Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
@esc

esc commented Jul 22, 2021

Copy link
Copy Markdown
Member

@ickc I have called on @stuartarchibald to help with the grammatical nuances, let's await their response.

@esc esc added the 5 - Ready to merge Review and testing done, is ready to merge label Jul 23, 2021
@esc

esc commented Jul 23, 2021

Copy link
Copy Markdown
Member

@ickc thank you!

@sklam
sklam merged commit d1b9e8c into numba:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to merge Review and testing done, is ready to merge Effort - short Short size effort needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants