Skip to content

PR #7171 bugfix only - #7230

Merged
sklam merged 5 commits into
numba:masterfrom
stuartarchibald:wip/pr_7171_split1
Jul 22, 2021
Merged

sklam merged 5 commits into
numba:masterfrom
stuartarchibald:wip/pr_7171_split1

Conversation

@stuartarchibald

Copy link
Copy Markdown
Contributor

Same as #7171 but just the bug fix components as discussed here: #7171 (comment)

CC @DrTodd13

DrTodd13 and others added 5 commits July 21, 2021 21:52
…e gufunc parallel processing. We don't need the parts like conversion to parfors and fusion.

2) Moved the code that adds debugging prints to the generated code after sequential lowering so that you get the prints from nested parfors.
3) The real bug fixed here was that merging the loop body into the gufunc in place of the sentinel wasn't recursively looking into nested parfors for labels.  I fixed this by using the ir_utils function find_max_label which does walk the blocks and checks in nested parfors.
As title. Postpone until 0.55.

@sklam sklam left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

@sklam sklam added 5 - Ready to merge Review and testing done, is ready to merge and removed 3 - Ready for Review labels Jul 22, 2021
@sklam
sklam merged commit 679cf7b into numba:master Jul 22, 2021
sklam added a commit to sklam/numba that referenced this pull request Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to merge Review and testing done, is ready to merge Effort - short Short size effort needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants