Skip to content

Replace assertion errors on IR assumption violation #7223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sklam merged 12 commits into from
Jul 30, 2021
Merged

Replace assertion errors on IR assumption violation #7223

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
359b5b0
Replace assertion errors on IR assumption violation
sklam Jul 20, 2021
e307287
pep8
sklam Jul 20, 2021
34dea22
pep8
sklam Jul 20, 2021
ec01acd
Use loc in warning class instead
sklam Jul 21, 2021
30a4cd2
Apply suggestions from code review
sklam Jul 21, 2021
d67e05d
Remove dead comments
sklam Jul 21, 2021
5463998
Update test to new error message
sklam Jul 21, 2021
9ffdd3d
Fix typo
sklam Jul 22, 2021
46a2f9f
Ask user to report the issue in pedantic warning msg.
sklam Jul 22, 2021
edc82f7
Replace "error" with "warning"
sklam Jul 22, 2021
d660e36
Update numba/core/errors.py
sklam Jul 29, 2021
3d6fb07
Add comments to explain the dummy function in test
sklam Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
pep8
  • Loading branch information
@sklam
sklam committed Jul 20, 2021
commit e3072870ea370b11b644920154b0a07ebaca3807
10 changes: 5 additions & 5 deletions numba/tests/test_ir.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,21 @@
from numba.core import ir, compiler
from numba.core import errors
from numba.core.compiler import (
CompilerBase,
CompilerBase,
ReconstructSSA,
)
from numba.core.compiler_machinery import (
FunctionPass,
FunctionPass,
PassManager,
register_pass,
)
from numba.core.untyped_passes import (
TranslateByteCode,
IRProcessing,
WithLifting,
)
from numba import njit


class TestIR(unittest.TestCase):

def test_IRScope(self):
Expand Down Expand Up @@ -515,7 +515,7 @@ def __init__(self, *args, **kwargs):
FunctionPass.__init__(self)

def run_pass(self, state):
# This is unreachable. SSA pass should have raised before this
# This is unreachable. SSA pass should have raised before this
# pass
raise AssertionError("unreachable")

Expand Down Expand Up @@ -553,7 +553,7 @@ def dummy(x):
str(raises.exception),
r"variable name '[a-z]' not in scope",

@stuartarchibald stuartarchibald Jul 21, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
r"variable name '[a-z]' not in scope",
r"variable '[a-z]' is not in scope",

)


if __name__ == '__main__':
unittest.main()