Skip to content

Fixes for lineinfo emission #7196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sklam merged 5 commits into from
Jul 15, 2021
Merged

Fixes for lineinfo emission #7196

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3631bdb
Fix up bug in lineinfo wrt decref
stuartarchibald Jul 2, 2021
f6bef9d
Handle lineinfo emission correctly across phi node stripping.
stuartarchibald Jul 9, 2021
5c3d7ae
Test for decref, undefined and versioned variables.
stuartarchibald Jul 14, 2021
2eacea6
Refactor unit tests to share common subprocess testing.
stuartarchibald Jul 14, 2021
8f1c198
Respond to feedback
stuartarchibald Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Handle lineinfo emission correctly across phi node stripping. 
As title.
  • Loading branch information
@stuartarchibald
stuartarchibald committed Jul 9, 2021
commit f6bef9de3ca480cf9c18138b236ac0854403d65c
7 changes: 4 additions & 3 deletions numba/core/typed_passes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,13 +843,14 @@ def _strip_phi_nodes(self, func_ir):
for target, rhs in exporters[label]:
# If RHS is undefined
if rhs is ir.UNDEFINED:
# Put in a NULL initializer
rhs = ir.Expr.null(loc=target.loc)
# Put in a NULL initializer, set the location to be in what
# will eventually materialize as the prologue.
rhs = ir.Expr.null(loc=func_ir.loc)

assign = ir.Assign(
>
value=rhs,
loc=target.loc
loc=rhs.loc
)
# Insert at the earliest possible location; i.e. after the
# last assignment to rhs
Expand Down