Skip to content

CUDA: Skip IPC tests on ARM #7189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sklam merged 1 commit into from
Jul 28, 2021
Merged

CUDA: Skip IPC tests on ARM #7189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
CUDA: Skip IPC tests on ARM 
These are unsupported on Tegra platforms (such as Jetson). There are
some CUDA ARM systems that support IPC, but for now we will count these
as not supported by Numba, and skip the tests regardless.

In the longer term (when we get to test Numba on CUDA ARM systems that
support IPC) this should be re-visited, either by finding a more precise
check for skipping the tests than just "Is the CPU architecture ARM?",
or by moving the IPC implementation to use `cuMemCreate()` and obtaining
shareable memory handles, which will be supported on Tegra.

Fixes #7178.
  • Loading branch information
@gmarkall
gmarkall committed Jul 6, 2021
commit 5f547c8c28a165cd29f654b53b03c31bcc3c4ddb
7 changes: 7 additions & 0 deletions numba/cuda/testing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import contextlib
import os
import platform
import shutil
import sys

Expand Down Expand Up @@ -99,6 +100,12 @@ def skip_with_nvdisasm(reason):
return unittest.skipIf(nvdisasm_path is not None, reason)


def skip_on_arm(reason):
cpu = platform.processor()
is_arm = cpu.startswith('arm') or cpu.startswith('aarch')
return unittest.skipIf(is_arm, reason)


def cc_X_or_above(major, minor):
if not config.ENABLE_CUDASIM:
cc = devices.get_context().device.compute_capability
Expand Down
6 changes: 5 additions & 1 deletion numba/cuda/tests/cudapy/test_ipc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
import numpy as np

from numba import cuda
from numba.cuda.testing import (skip_on_cudasim, skip_under_cuda_memcheck,
from numba.cuda.testing import (skip_on_arm, skip_on_cudasim,
skip_under_cuda_memcheck,
ContextResettingTestCase, ForeignArray)
import unittest

Expand Down Expand Up @@ -78,7 +79,9 @@ def ipc_array_test(ipcarr, result_queue):

@skip_under_cuda_memcheck('Hangs cuda-memcheck')
@skip_on_cudasim('Ipc not available in CUDASIM')
@skip_on_arm('CUDA IPC not supported on ARM in Numba')
class TestIpcMemory(ContextResettingTestCase):

def test_ipc_handle(self):
# prepare data for IPC
arr = np.arange(10, dtype=np.intp)
Expand Down Expand Up @@ -227,6 +230,7 @@ def staged_ipc_array_test(ipcarr, device_num, result_queue):

@skip_under_cuda_memcheck('Hangs cuda-memcheck')
@skip_on_cudasim('Ipc not available in CUDASIM')
@skip_on_arm('CUDA IPC not supported on ARM in Numba')
class TestIpcStaged(ContextResettingTestCase):
def test_staged(self):
# prepare data for IPC
Expand Down