Repository navigation
Fix issue in bytecode analysis where target and next are same. - #7149
Merged
Merged
Conversation
As title. Fixes numba#5097 Fixes numba#5680
stuartarchibald
added
3 - Ready for Review
Effort - short
Member
|
This fixes the issue for my reproducer too: from numba import cuda
import numpy as np
@cuda.jit(debug=True)
def f(x, y):
i = 0
for xv, yv in zip(x, y):
if xv != x[i]:
pass
i += 1
x = np.asarray((10, 9, 8, 7, 6))
y = np.asarray((1, 2, 3, 4, 5))
f[1, 1](x, y)which used to fail with: |
sklam
approved these changes
Jun 25, 2021
sklam
left a comment
sklam
left a comment
Member
There was a problem hiding this comment.
I confirmed that this patch works.
btw, I'm surprise to see that this can happen and CPython is not optimizing it into a unconditional-jump
sklam
added
5 - Ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title.
Fixes #5097
Fixes #5680