Repository navigation
Rtd/sphinx compat - #7122
Merged
Merged
Rtd/sphinx compat#7122
Conversation
As title
As title
Member
Author
|
Build is here: https://readthedocs.org/projects/numba/builds/14032023/ |
Member
Author
|
RTD Build passed: https://readthedocs.org/projects/numba/builds/14032023/ |
Contributor
|
These type of URLs are working again! https://numba--7122.org.readthedocs.build/en/7122/ |
stuartarchibald
approved these changes
Jun 17, 2021
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch.
Contributor
|
Question... Does this create a minimum sphinx version requirement or is the patch backward compatible? |
stuartarchibald
added
5 - Ready to merge
Member
Author
|
Deprecated since 1.8, removed with 4.0 -- yes, new minimum sphinx is now 4.0 |
Contributor
Thanks, I guess we need to fix up the recipes and add a note in the docs too. Anything else? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix the failing RTD builds, inspired by:
sphinx-doc/sphinx#7747