Repository navigation
Initialize NUMBA_DEFAULT_NUM_THREADS with a batch scheduler aware value - #7088
Merged
Merged
Conversation
Member
|
Thanks very much for the PR, I've queued it for review. |
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch. One minor thing to resolve else good to merge. Thanks again.
Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
Contributor
Author
|
I applied your patch, thanks. |
stuartarchibald
approved these changes
Jun 14, 2021
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch and fixes.
Contributor
|
@t20100 Congratulations on your first contribution to Numba! |
Contributor
|
Just for reference, this was tested as follows: $ cat test_7088.py
from numba import njit, prange, get_num_threads
import numpy as np
@njit(parallel=True)
def foo(n):
acc = 0
for x in prange(n):
acc += x
return acc
foo(100)
print(f"get_num_threads(): {get_num_threads()}")
$ python test_7088.py # default, 4 cores on this machine, all accessible
get_num_threads(): 4
$ taskset 0x00000003 python test_7088.py # restrict to cores #0 and #1.
get_num_threads(): 2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the value of
NUMBA_DEFAULT_NUM_THREADSto use a batch-scheduler aware number of CPU cores throughlen(os.sched_getaffinity(0))when available.closes #7086