Repository navigation
Improve the issue templates and pull request template. - #7070
Conversation
|
@guoqiangqi thank you for your suggestion. We will have to discuss this tomorrow in the developer meeting, but personally I am +1 on this. Also, could you maybe add a section about checking via Gitter first? if unsure if this is a bug or not? Since the requested answers in the new template are somewhat more involved and I'd like to largely prevent want someone to go through all of the fact gathering to report what then turns out to be a user-error or similar. |
…ort issue, and keep the original check list.
@esc Sorry about the delay, i have updated this part of code. |
|
|
||
| --> | ||
|
|
||
| ## Reference issue |
|
@guoqiangqi thank you again for submitting this improvement! We had a conversation about this in the developer meeting yesterday and it turns out, we had refactored the pull-request template to make it simpler! We do see your intention to improve the Numba pull-request and issue-reporting -- but we feel this may be asking a bit too much from our users. I think the main questions that need to be answered are:
And then have a runnable (including imports, the code in question and a line or lines to execute it) script to reproduce the bug. Anything else, we can always ask about or request the output of Anyhow , the part about "reference an existing issue, if it exists" was well received and will be merged, so that's good! So, I think @guoqiangqi you may modify the PR to include the suggestion about adding a link to a PR and we will merge that! Thank you again for you efforts on this front and your help to improve Numba! |
|
@esc Agree with you, we should not make the templates complex , it may make issue reporting more complicated. New code has been uploaded. |
|
@guoqiangqi Congratulations on your first contribution to Numba! @esc thanks for reviewing. |
Provide better issue templates and pull request template.