Repository navigation
Enhancing docs about PRNG seeding - #7068
Merged
Merged
Conversation
Member
|
@jeertmans Looks good, thank you! |
Contributor
Author
|
Thanks @esc ! |
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch. Good to see this documented. A few minor suggestions to resolve else looks good.
stuartarchibald
added
4 - Waiting on author
Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
Contributor
Author
Thanks for the review @stuartarchibald ! Agreed with your suggestions |
stuartarchibald
approved these changes
Jun 1, 2021
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch and fixes!
stuartarchibald
added
5 - Ready to merge
Contributor
|
Thanks for reviewing @esc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This PR directly follows my proposition in #6002.
The goal was to enhance the current documentation to be more clear about PRNG seeding. A note was already present for the Python
randommodule but not the the NumPy one.It took the liberty to add a minimal working example in both cases, as well as labelling it as a warning to have more impact.
I will gladly accept any comment or suggestion from your side.
Thanks :-)
Updated doc.
Python
NumPy