Repository navigation
Fix nrt debug print - #7027
Merged
Merged
Fix nrt debug print#7027
Conversation
Member
|
Good catch on the |
stuartarchibald
approved these changes
May 19, 2021
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a byproduct of me trying to fix generators. Without this PR I get output like this
This is because the call to
printfwas essentiallyThe problem here is that the type of
ptrisint8*., meaning the a value of typeint8was passed toprintfwhen it expected a value of typeuint64. This is undefined behaviour and apparently didn't break for others. I now changed it to be:which does work correctly for me.
At request of @gmarkall I also added a config variable 'NUMBA_DEBUG_NRT' to replace the global
_debug_printinnrtdynmod