Skip to content

Remove cu{blas,sparse,rand,fft} from library checks - #7018

Merged
sklam merged 1 commit into
numba:masterfrom
gmarkall:grm-cuda-remove-some-lib-checks
May 12, 2021
Merged

sklam merged 1 commit into
numba:masterfrom
gmarkall:grm-cuda-remove-some-lib-checks

Conversation

@gmarkall

Copy link
Copy Markdown
Member

These libraries are not needed by Numba, and pyculib, which used them,
is deprecated / discontinued. There is therefore no point in checking
for these libraries.

Prior to this commit, the library check:

$ python -c "from numba import cuda; cuda.cudadrv.libs.test()"

gave (for example):

Finding cublas from System
	located at /usr/local/cuda/lib64/libcublas.so.11.2.2.29
	trying to open library...	ok
Finding cusparse from System
	located at /usr/local/cuda/lib64/libcusparse.so.11.3.1.29
	trying to open library...	ok
Finding cufft from System
	located at /usr/local/cuda/lib64/libcufft.so.10.4.0.29
	trying to open library...	ok
Finding curand from System
	located at /usr/local/cuda/lib64/libcurand.so.10.2.3.29
	trying to open library...	ok
Finding nvvm from System
	located at /usr/local/cuda/nvvm/lib64/libnvvm.so.4.0.0
	trying to open library...	ok
Finding cudart from System
	located at /usr/local/cuda/lib64/libcudart.so.11.2.29
	trying to open library...	ok
Finding cudadevrt from System
	located at /usr/local/cuda/lib64/libcudadevrt.a
Finding libdevice from System
	searching for compute_20...	ok
	searching for compute_30...	ok
	searching for compute_35...	ok
	searching for compute_50...	ok

Now it only prints:

Finding nvvm from System
	located at /usr/local/cuda/nvvm/lib64/libnvvm.so.4.0.0
	trying to open library...	ok
Finding cudart from System
	located at /usr/local/cuda/lib64/libcudart.so.11.2.29
	trying to open library...	ok
Finding cudadevrt from System
	located at /usr/local/cuda/lib64/libcudadevrt.a
Finding libdevice from System
	searching for compute_20...	ok
	searching for compute_30...	ok
	searching for compute_35...	ok
	searching for compute_50...	ok

These libraries are not needed by Numba, and pyculib, which used them,
is deprecated / discontinued. There is therefore no point in checking
for these libraries.

Prior to this commit, the library check:

```
$ python -c "from numba import cuda; cuda.cudadrv.libs.test()"
```

gave (for example):

```
Finding cublas from System
	located at /usr/local/cuda/lib64/libcublas.so.11.2.2.29
	trying to open library...	ok
Finding cusparse from System
	located at /usr/local/cuda/lib64/libcusparse.so.11.3.1.29
	trying to open library...	ok
Finding cufft from System
	located at /usr/local/cuda/lib64/libcufft.so.10.4.0.29
	trying to open library...	ok
Finding curand from System
	located at /usr/local/cuda/lib64/libcurand.so.10.2.3.29
	trying to open library...	ok
Finding nvvm from System
	located at /usr/local/cuda/nvvm/lib64/libnvvm.so.4.0.0
	trying to open library...	ok
Finding cudart from System
	located at /usr/local/cuda/lib64/libcudart.so.11.2.29
	trying to open library...	ok
Finding cudadevrt from System
	located at /usr/local/cuda/lib64/libcudadevrt.a
Finding libdevice from System
	searching for compute_20...	ok
	searching for compute_30...	ok
	searching for compute_35...	ok
	searching for compute_50...	ok
```

Now it only prints:

```
Finding nvvm from System
	located at /usr/local/cuda/nvvm/lib64/libnvvm.so.4.0.0
	trying to open library...	ok
Finding cudart from System
	located at /usr/local/cuda/lib64/libcudart.so.11.2.29
	trying to open library...	ok
Finding cudadevrt from System
	located at /usr/local/cuda/lib64/libcudadevrt.a
Finding libdevice from System
	searching for compute_20...	ok
	searching for compute_30...	ok
	searching for compute_35...	ok
	searching for compute_50...	ok
```
@gmarkall gmarkall added CUDA CUDA related issue/PR Effort - short Short size effort needed labels May 12, 2021

@stuartarchibald stuartarchibald left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch.

@stuartarchibald stuartarchibald added 4 - Waiting on CI Review etc done, waiting for CI to finish Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm labels May 12, 2021
@stuartarchibald stuartarchibald added this to the Numba 0.54 RC milestone May 12, 2021
@stuartarchibald

Copy link
Copy Markdown
Contributor

Buildfarm ID: numba_smoketest_cuda_yaml_58.

@stuartarchibald

Copy link
Copy Markdown
Contributor

Buildfarm ID: numba_smoketest_cuda_yaml_58.

Passed.

@stuartarchibald stuartarchibald added BuildFarm Passed For PRs that have been through the buildfarm and passed 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on CI Review etc done, waiting for CI to finish Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm labels May 12, 2021
@sklam
sklam merged commit d4d09f3 into numba:master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to merge Review and testing done, is ready to merge BuildFarm Passed For PRs that have been through the buildfarm and passed CUDA CUDA related issue/PR Effort - short Short size effort needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants