Repository navigation
Remove cu{blas,sparse,rand,fft} from library checks - #7018
Merged
Merged
Conversation
These libraries are not needed by Numba, and pyculib, which used them, is deprecated / discontinued. There is therefore no point in checking for these libraries. Prior to this commit, the library check: ``` $ python -c "from numba import cuda; cuda.cudadrv.libs.test()" ``` gave (for example): ``` Finding cublas from System located at /usr/local/cuda/lib64/libcublas.so.11.2.2.29 trying to open library... ok Finding cusparse from System located at /usr/local/cuda/lib64/libcusparse.so.11.3.1.29 trying to open library... ok Finding cufft from System located at /usr/local/cuda/lib64/libcufft.so.10.4.0.29 trying to open library... ok Finding curand from System located at /usr/local/cuda/lib64/libcurand.so.10.2.3.29 trying to open library... ok Finding nvvm from System located at /usr/local/cuda/nvvm/lib64/libnvvm.so.4.0.0 trying to open library... ok Finding cudart from System located at /usr/local/cuda/lib64/libcudart.so.11.2.29 trying to open library... ok Finding cudadevrt from System located at /usr/local/cuda/lib64/libcudadevrt.a Finding libdevice from System searching for compute_20... ok searching for compute_30... ok searching for compute_35... ok searching for compute_50... ok ``` Now it only prints: ``` Finding nvvm from System located at /usr/local/cuda/nvvm/lib64/libnvvm.so.4.0.0 trying to open library... ok Finding cudart from System located at /usr/local/cuda/lib64/libcudart.so.11.2.29 trying to open library... ok Finding cudadevrt from System located at /usr/local/cuda/lib64/libcudadevrt.a Finding libdevice from System searching for compute_20... ok searching for compute_30... ok searching for compute_35... ok searching for compute_50... ok ```
stuartarchibald
approved these changes
May 12, 2021
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch.
Contributor
|
Buildfarm ID: |
Contributor
Passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These libraries are not needed by Numba, and pyculib, which used them,
is deprecated / discontinued. There is therefore no point in checking
for these libraries.
Prior to this commit, the library check:
gave (for example):
Now it only prints: