Skip to content

Fix errors introduced by the cloudpickle patch - #6999

Merged
sklam merged 3 commits into
numba:masterfrom
sklam:fix/cloudpickle_fallout
May 4, 2021
Merged

Fix errors introduced by the cloudpickle patch#6999
sklam merged 3 commits into
numba:masterfrom
sklam:fix/cloudpickle_fallout

Conversation

@sklam

@sklam sklam commented May 4, 2021

Copy link
Copy Markdown
Member
  • Revert removal of _RedirectSubpackage
  • pin pickle protocol to 4

@sklam
sklam requested review from esc and stuartarchibald as code owners May 4, 2021 16:43
@sklam sklam added this to the Numba 0.54 RC milestone May 4, 2021
@sklam sklam mentioned this pull request May 4, 2021
Closed
@sklam sklam added the Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm label May 4, 2021
@sklam

sklam commented May 4, 2021

Copy link
Copy Markdown
Member Author

BFID numba_smoketest_cpu_yaml_18

stuartarchibald
stuartarchibald approved these changes May 4, 2021
View reviewed changes

@stuartarchibald stuartarchibald left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch.

@stuartarchibald stuartarchibald added 4 - Waiting on CI Review etc done, waiting for CI to finish and removed 3 - Ready for Review labels May 4, 2021
@sklam

sklam commented May 4, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

BF failed.
This is introducing segfault in numba.tests.test_parallel_backend.

@sklam

sklam commented May 4, 2021

Copy link
Copy Markdown
Member Author

At this point, i'm not sure if the failing in test_parallel_backend is a pre-existing problem.

@sklam sklam added 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on CI Review etc done, waiting for CI to finish Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm labels May 4, 2021
@sklam
sklam merged commit 5197876 into numba:master May 4, 2021
@sklam
sklam deleted the fix/cloudpickle_fallout branch May 4, 2021 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartarchibald stuartarchibald stuartarchibald approved these changes
@esc esc Awaiting requested review from esc

Assignees

No one assigned

Labels

5 - Ready to merge Review and testing done, is ready to merge

Projects

None yet

Milestone

Numba 0.54 RC

Development

Successfully merging this pull request may close these issues.

2 participants

@sklam @stuartarchibald