Repository navigation
Refactor hardware extension API to refer to "target" instead. - #6990
Merged
sklam merged 3 commits intoMay 11, 2021
Merged
Conversation
As title. This is a largely mechanical refactor. It changes the new hardware extension API to refer to "target" instead of "hardware". This is because the "hardware" is often actually synthetic and "target" better describes this.
Contributor
Author
|
Notes:
|
As title. This keeps all the registration mechanics in the same place.
gmarkall
reviewed
May 5, 2021
gmarkall
left a comment
gmarkall
left a comment
Member
There was a problem hiding this comment.
This looks good and tests OK with the CUDA target for me locally on Linux.
I've looked through the CUDA changes and they look fine - I've also read through the rest of the PR and it seems OK to the extent that I could understand the changes.
I've made one small suggestion on the diff, but it's not a deal breaker for me. :-)
|
|
||
| cuda_hw = hardware_registry["cuda"] | ||
| decorators.jit_registry[cuda_hw] = cuda_jit_device | ||
| cuda_hw = target_registry["cuda"] |
Member
There was a problem hiding this comment.
This probably makes more sense as cuda_target now than cuda_hw.
As title
sklam
approved these changes
May 11, 2021
sklam
left a comment
sklam
left a comment
Member
There was a problem hiding this comment.
LGTM.
While not introduced by this PR, numba/tests/test_target_extension.py can use some refactoring in a future PR. There are code duplicated and unused code in there.
sklam
added
Pending BuildFarm
Member
|
BFID |
sklam
added
5 - Ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title. This is a largely mechanical refactor. It changes the
new hardware extension API to refer to "target" instead of
"hardware". This is because the "hardware" is often actually
synthetic and "target" better describes this.