Repository navigation
Update _Intrinsic for sphinx to capture the inner docstring - #6915
Merged
Merged
Conversation
sklam
added
3 - Ready for Review
Effort - short
guilhermeleobas
marked this pull request as ready for review
April 12, 2021 16:06
guilhermeleobas
requested review from
esc,
sklam and
stuartarchibald
as code owners
April 12, 2021 16:06
sklam
approved these changes
Apr 13, 2021
| self.assertEqual("void_func", void_func.__name__) | ||
| self.assertEqual("TestIntrinsic.test_docstring.<locals>.void_func", | ||
| void_func.__qualname__) | ||
| self.assertDictEqual({'a': int}, void_func.__annotations__) |
Member
There was a problem hiding this comment.
I wasn't aware these were added. I'll need to try in my next PR.
Contributor
Author
There was a problem hiding this comment.
functools.update_wrapper updates the following fields: __module__, __name__, __qualname__, __annotations__ and __doc__ (ref)
Member
There was a problem hiding this comment.
oops, I mean assertDictEqual, not anything particular in your PR. (I was rushing to finish up the review before starting a meeting and didn't realize the confusing comment.)
sklam
added
5 - Ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title.
This also fixes #6308