Repository navigation
CUDA: Support passing tuples to ufuncs - #6878
Merged
Merged
Conversation
This commit adds support for use cases like the following to CUDA ufuncs created with `@vectorize`: ``` from numba import vectorize, float64 import math @vectorize([float64(float64)],) def cuda_cos(x): return math.cos(x) print(cuda_cos((1.0, 2.0, 3.0))) ``` Passing tuples, namedtuples, tuples of arrays, and nesting of these is supported - tests are added to cover some of these cases. It seems that this already worked for gufuncs, so some tests are added for the equivalent in gufuncs, but no functional change is made there. Fixes numba#6563.
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch, one minor query else looks good.
stuartarchibald
approved these changes
May 10, 2021
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch and fixes.
Contributor
|
Buildfarm ID: |
Contributor
Passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for use cases like the following to CUDA ufuncs created with
@vectorize:Passing tuples, namedtuples, tuples of arrays, and nesting of these is supported - tests are added to cover some of these cases.
It seems that this already worked for gufuncs, so some tests are added for the equivalent in gufuncs, but no functional change is made there.
Fixes #6563.