Repository navigation
Add __hash__ for IntEnum - #6849
Merged
Merged
Conversation
Contributor
|
Thanks for the patch @HPLegion
It's encouraged! |
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch, one minor thing to resolve else looks good.
stuartarchibald
added
4 - Waiting on author
stuartarchibald
approved these changes
Mar 22, 2021
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch and fixes.
stuartarchibald
added
5 - Ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi :-)
Partially solving #5911
This patch adds
__hash__capability for IntEnums. I think this would be a nice addition, because I like to use enums as keys for the typedDict, since there is less risk of introducing typos.I have been using this inside my own code for a while, but I had mistakenly thought that the hashes I created are different from the CPython hashes.
Today I realised that the CPython hash for an IntEnum is in fact simply
int.__hash__ (value)so I think this could move into numba.Is it frowned upon to use the extension API for internals?
Cheers!