Skip to content

cross-referenced Array type in docs - #6843

Merged
sklam merged 4 commits into
numba:masterfrom
rawwar:adding_array_ref_in_types_doc
Mar 23, 2021
Merged

sklam merged 4 commits into
numba:masterfrom
rawwar:adding_array_ref_in_types_doc

Conversation

@rawwar

@rawwar rawwar commented Mar 18, 2021

Copy link
Copy Markdown
Contributor

Updated Array explanation to contain a reference to Array class definition.

image

@rawwar rawwar changed the title cross-referenced Array type in explanation cross-referenced Array type in docs Mar 19, 2021

@stuartarchibald stuartarchibald left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, looks good, just needs line wrapping.

Comment thread docs/source/reference/types.rst Outdated
@stuartarchibald

Copy link
Copy Markdown
Contributor

@stuartarchibald stuartarchibald added the 4 - Waiting on author Waiting for author to respond to review label Mar 19, 2021
@stuartarchibald stuartarchibald added this to the Numba 0.54 RC milestone Mar 19, 2021
@rawwar

rawwar commented Mar 19, 2021

Copy link
Copy Markdown
Contributor Author

I updated the docs.

@stuartarchibald stuartarchibald added the Effort - short Short size effort needed label Mar 22, 2021

@stuartarchibald stuartarchibald left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch.

@stuartarchibald stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on author Waiting for author to respond to review labels Mar 23, 2021
@sklam
sklam merged commit ecb9ba6 into numba:master Mar 23, 2021
@rawwar
rawwar deleted the adding_array_ref_in_types_doc branch March 26, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to merge Review and testing done, is ready to merge Effort - short Short size effort needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants