Repository navigation
ParallelAccelerator no long will convert StaticSetItem to SetItem because record arrays require StaticSetItems. - #6801
Merged
Merged
Conversation
… to record handling requiring StaticSetItem.
sklam
requested changes
Mar 8, 2021
sklam
left a comment
sklam
left a comment
Member
There was a problem hiding this comment.
I've suggested additional test to improve coverage.
sklam
added
4 - Waiting on author
Co-authored-by: Siu Kwan Lam <1929845+sklam@users.noreply.github.com>
DrTodd13
added
4 - Waiting on reviewer
Contributor
|
Open/Close was to try and re-start the RTD docs build. |
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch, couple of minor things else looks good.
stuartarchibald
added
4 - Waiting on author
Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
DrTodd13
added
4 - Waiting on reviewer
stuartarchibald
approved these changes
Mar 23, 2021
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch and fixes. @sklam's unit test is added so I think everything is resolved.
stuartarchibald
added
5 - Ready to merge
sklam
approved these changes
Mar 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6704.