Repository navigation
refactor and move create_temp_module into numba.tests.support - #6794
Merged
sklam merged 2 commits intoMar 8, 2021
Merged
Conversation
Alexander-Makaryev
requested review from
esc,
sklam and
stuartarchibald
as code owners
March 4, 2021 09:20
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for doing this refactoring, patch looks good, just one suggestion about adding a docstring else good to go.
stuartarchibald
added
4 - Waiting on author
stuartarchibald
approved these changes
Mar 8, 2021
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Many thanks for the patch and fixes!
stuartarchibald
added
5 - Ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6778
This is a refactoring of code duplication.
Please look at issue for more details.