Repository navigation
Fix DeviceNDArray null shape issue - #6766
Merged
Merged
Conversation
Contributor
|
Thanks for the patch @testhound . CI failure is unrelated. |
stuartarchibald
added
CUDA
gmarkall
approved these changes
Feb 26, 2021
gmarkall
left a comment
gmarkall
left a comment
Member
There was a problem hiding this comment.
This looks good to me! It passes all tests locally with hardware and the simulator.
Member
|
@esc could this have a buildfarm run please? |
Member
|
Buildfarm ID: |
Member
|
BF passed! |
esc
added
BuildFarm Passed
Member
|
Many thanks for the run - marking as RTM accordingly. |
Contributor
|
/AzurePipelines run |
Contributor
|
Azure Pipelines successfully started running 1 pipeline(s). |
stuartarchibald
approved these changes
Mar 4, 2021
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Patch looks good, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves: #5234. I was able to utilize the patch posted in the issue and added a test case.