Repository navigation
Fix #6130 objmode cache segfault - #6141
Merged
Merged
Conversation
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch, great to see this fixed.
stuartarchibald
added
4 - Waiting on author
Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
sklam
added
4 - Waiting on reviewer
eric-wieser
reviewed
Aug 21, 2020
eric-wieser
reviewed
Aug 21, 2020
stuartarchibald
added
4 - Waiting on author
sklam
added
4 - Waiting on reviewer
stuartarchibald
added
4 - Waiting on author
- changed to RuntimeError and fix error message - added suggested comment
sklam
added
4 - Waiting on reviewer
Member
Author
|
failing due to: #6168 |
Contributor
|
/AzurePipelines run |
Contributor
|
Azure Pipelines successfully started running 1 pipeline(s). |
stuartarchibald
approved these changes
Aug 25, 2020
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fixes!
stuartarchibald
added
5 - Ready to merge
sklam
added
5 - Ready to merge
Member
Author
|
CI passed, marked for merge |
21 tasks done
stuartarchibald
pushed a commit
to stuartarchibald/numba
that referenced
this pull request
Aug 26, 2020
Fix numba#6130 objmode cache segfault
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6130
Thanks @juanjgalvez and @stuartarchibald for finding out the source of the problem on the lost
env.The patch makes sure the
CompileResultacquires a reference to any referencedEnvironmentobjects. Changes tonumba/core/compiler.pyis the actual fix. The other non-test changes are for better error handling when an NULL pointer is encountered.