Repository navigation
Fix issue with cross drive use and relpath. - #6081
Merged
Merged
Conversation
As title. On windows relpath does not work across drives as they technically do not share the same root. A utility function is added to provide a "safe" relpath like function for use in future. Previous fix was numba#5319.
stuartarchibald
added
the
Pending BuildFarm
Member
|
Running reduced DAG of only Win-32 tests at BFID: |
Member
|
The changes make sense. I think this is just waiting on BF to check for missing unpatched relpath. |
sklam
approved these changes
Aug 5, 2020
As title.
As title.
esc
added
BuildFarm Passed
Merged
31 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title. On windows relpath does not work across drives as they
technically do not share the same root. A utility function is
added to provide a "safe" relpath like function for use in future.
Previous fix was #5319.