Repository navigation
Complete dead code sweep for numba/np/math/numbers.py - #10791
Merged
Merged
Conversation
esc
changed the title
numba/np/math/numbers.py
Member
Author
|
@swap357 some remaining dead-code removal that Kimi found. I did verify by looking for references and the tests pass too, can you take a look please? |
swap357
reviewed
Aug 20, 2026
swap357
left a comment
swap357
left a comment
Contributor
There was a problem hiding this comment.
found one more thing to cleanup, otherwise I verified the other removed stuff have no remaining callers. looks good
Contributor
There was a problem hiding this comment.
can we cleanup this leftover decorator as well ?
esc
added
4 - Waiting on reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup from #10542 -- some more dead code and a comment that needed updating.
Assisted-by: Kilo (Kimi K3)