Repository navigation
np.ufunc type stubs (threading functions and PyUFunc_*) - #10739
Merged
Merged
Conversation
np.ufunc type stubs (threading functions and PyUFunc_* constants)np.ufunc type stubs (threading functions and PyUFunc_*)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quick code search showed that these threading functions (documented in https://numba.readthedocs.io/en/stable/user/threading-layer.html) are used quite a lot, so I figured it'd help to stub them.
These threading functions actually live in
numba.np.ufunc.parallel. But that module also contains a bunch of publically-named undocumented functions and classes. If I would've stubbed that module directly, then stubtest would've required me to stub everything there, which seemed like a waste of time.These functions are re-exported in
__init__.py, so it's a lot easier to place the stubs in this__init__.pyi. However, because this__init__.pyalso re-exports some constants from the C-extension modulenumba.np.ufunc._internal, I also had to stub these constants.Anway, the stubs themselves are all very straightforward stuff.
Note that the vectorize/guvectorize re-exports here are not yet typed, see #10715. It's fine to merge this before, though.