fix(discord): recover closed gateway sockets - #953
Open
vernonstinebaker wants to merge 4 commits into
Open
vernonstinebaker wants to merge 4 commits into
vernonstinebaker wants to merge 4 commits into
Conversation
…lose-before-heartbeat-join
Close Discord resume and descriptor races, serialize socket publication/shutdown/final close across WebSocket channels, and bound QQ gateway health before and after HELLO. Keep final close with WsClient after worker joins. Risk: lifecycle-only; no protocol permissions or credentials change. Regression coverage uses socket pairs. Validated with full tests and ReleaseSmall.
…lose-before-heartbeat-join
Contributor
Author
|
Merged into the |
vernonstinebaker
pushed a commit
to vernonstinebaker/nullclaw
that referenced
this pull request
Sep 23, 2026
…sted Approved intake U-1/U-2/U-4 complete and upstream authors notified with commit links and intake-correction feedback. Landed-in-fork notes added to our nine still-open upstream PRs (nullclaw#987, nullclaw#971, nullclaw#970, nullclaw#966, nullclaw#963, nullclaw#962, nullclaw#959, nullclaw#954, nullclaw#953). Upstream PRs cannot be marked merged (no write access; re-applied commits never trigger GitHub merge detection), so these comments are the provenance record.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
HOME=$(mktemp -d ...) zig build test --summary allRisk