Repository navigation
fix(tsx loader): can't find esbuild config (parentURL unavailable in load hook) - #54
Closed
AugustinMauroy wants to merge 9 commits into
Closed
AugustinMauroy wants to merge 9 commits into
AugustinMauroy wants to merge 9 commits into
Conversation
JakobJingleheimer
left a comment
JakobJingleheimer
left a comment
Member
There was a problem hiding this comment.
Thanks for discovering and jumping on this!
Co-Authored-By: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
AugustinMauroy
force-pushed
the
fix-tsx
branch
from
December 14, 2024 21:23
eb86097 to
8a509a7
Compare
Member
Author
|
now it's look good for me. But there are still the issue with |
AugustinMauroy
marked this pull request as ready for review
December 14, 2024 21:25
JakobJingleheimer
changed the title
parentURL unavailable in load hook)
AugustinMauroy
commented
Dec 15, 2024
AugustinMauroy
commented
Dec 15, 2024
this still doesn't work because of a bug in `findPackageJSON` where `cascadedLoader.resolve` returns a promise when there are async resolve hooks in the chain. this is especially problematic from within a loader because we can't use Atomics magic: we're _already_ in the hooks thread.
Member
|
This is caused by a bug in node's Edit: nodejs/node#56382 |
Member
Author
|
close in favor for #70 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.