This repository was archived by the owner on Apr 22, 2023. It is now read-only.
Repository navigation
Conversation
sonnyp
changed the title
sonnyp
changed the title
|
LGTM. Can you update the commit message to conform to CONTRIBUTING.md |
Member
In cluster documentation, "Class: Worker" id property had wrong type.
Author
Author
|
ping |
Member
|
Closing this here. Opened a new PR in http://github.com/nodejs/node with this bundled up with a number of other doc related commits. |
jasnell
added a commit
to jasnell/node
that referenced
this pull request
Aug 26, 2015
per: nodejs/node-v0.x-archive#25459 originally submitted by @sonnyp
jasnell
added a commit
to nodejs/node
that referenced
this pull request
Aug 26, 2015
per: nodejs/node-v0.x-archive#25459 originally submitted by @sonnyp Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: #2378
jasnell
added a commit
to nodejs/node
that referenced
this pull request
Aug 26, 2015
per: nodejs/node-v0.x-archive#25459 originally submitted by @sonnyp Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: #2378
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation on worker.id is wrong, it's a number not a string.
See
https://github.com/joyent/node/blob/master/lib/cluster.js#L51
https://github.com/joyent/node/blob/master/lib/cluster.js#L335
https://github.com/joyent/node/blob/master/lib/cluster.js#L525