Skip to content

Add git node staging command #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ruyadorno wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add git node staging command #875

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
03936ce
chore: stopping spinner with no text skips persist
ruyadorno Nov 25, 2024
1356262
chore: add captureStderr option to runAsyncBase
ruyadorno Nov 25, 2024
3afe24f
chore: add lib/run.js unit tests
ruyadorno Dec 19, 2024
dd6402b
feat: add git node staging command
ruyadorno Nov 25, 2024
0619431
fixup! feat: add git node staging command
RafaelGSS Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: add captureStderr option to runAsyncBase 
Added a `captureStderr` option to `lib/run.js` `runAsyncBase` method
that allows for adding stderr information to thrown errors.
  • Loading branch information
@ruyadorno
ruyadorno committed Dec 19, 2024
commit 1356262cc367f67982ad8dd118ded1827bb08c1f
18 changes: 16 additions & 2 deletions lib/run.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,19 @@ function runAsyncBase(cmd, args, {
ignoreFailure = true,
spawnArgs,
input,
captureStdout = false
captureStdout = false,
captureStderr = false
} = {}) {
if (cmd instanceof URL) {
cmd = fileURLToPath(cmd);
}
let stdio = 'inherit';
if (captureStdout || input != null) {
stdio = [input == null ? 'inherit' : 'pipe', captureStdout ? 'pipe' : 'inherit', 'inherit'];
stdio = [
input == null ? 'inherit' : 'pipe',
captureStdout ? 'pipe' : 'inherit',
captureStderr ? 'pipe' : 'inherit'
];
}
return new Promise((resolve, reject) => {
const opt = Object.assign({
Expand All @@ -36,13 +41,22 @@ function runAsyncBase(cmd, args, {
child.stdout.setEncoding('utf8');
child.stdout.on('data', (chunk) => { stdout += chunk; });
}
let stderr;
if (captureStderr) {
stderr = '';
child.stderr.setEncoding('utf8');
child.stderr.on('data', (chunk) => { stderr += chunk; });
}
child.on('error', reject);
child.on('close', (code) => {
if (code !== 0) {
if (ignoreFailure) {
return reject(new Error(IGNORE));
}
const err = new Error(`${cmd} ${args} failed: ${code}`);
if (stderr) {
err.stderr = stderr;
}
err.code = code;
err.messageOnly = true;
return reject(err);
Expand Down