Skip to content

feat: add --releaseDate to git node release #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 3 commits into from
Nov 2, 2024
Merged

feat: add --releaseDate to git node release #863

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e665835
feat: add --releaseDate to git node release
RafaelGSS Nov 2, 2024
470bcf1
Update lib/prepare_release.js
RafaelGSS Nov 2, 2024
ca4b89e
Apply suggestions from code review
RafaelGSS Nov 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lib/prepare_release.js 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@RafaelGSS @aduh95
RafaelGSS and aduh95 authored Nov 2, 2024
commit 470bcf13bdfafe62d56f6051494475b9f91fb1df
2 changes: 1 addition & 1 deletion lib/prepare_release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export default class ReleasePreparation extends Session {
this.isLTS = false;
this.isLTSTransition = argv.startLTS;
this.runBranchDiff = !argv.skipBranchDiff;
this.defaultReleaseDate = argv.releaseDate ?? new Date().toISOString().split('T')[0];
this.defaultReleaseDate = argv.releaseDate ?? new Date().toISOString().slice(0, 10);
this.ltsCodename = '';
this.date = '';
this.filterLabels = argv.filterLabel && argv.filterLabel.split(',');
Expand Down