Repository navigation
feat(git-node): add release promotion step #835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
9ee6605
git-node: add release promotion step
codebytere 15c4cb0
Move newVersion to named arg
codebytere 0ec3327
Split out promotion verification steps
codebytere a1c3ef1
Fix verification spinners
codebytere 61dbeb7
Verify ncurc is set up
codebytere ea29f87
Properly trim getCommitSha result
codebytere c0db1ce
Address some feedback
codebytere 7d23d70
Ensure synced with upstream/master
codebytere 692c6b7
fix: run release script asynchronously
codebytere c1ab158
Run secureTagRelease() asynchronously
codebytere ddfe6ef
Run cherry-pick asynchronously
codebytere 3377b44
Remove unneccessary quotes
codebytere 88b99f3
Merge branch 'main' of https://github.com/nodejs/node-core-utils
aduh95 a08566d
nits
aduh95 0229ccf
esm
aduh95 ba23781
some refactor + more checks
aduh95 8ef8c41
fixup! Merge branch 'main' of https://github.com/nodejs/node-core-utils
aduh95 8d02a41
throw on error to get non-zero exit code
aduh95 15c0335
lint
aduh95 ce72380
validate CHANGELOG heading
aduh95 519388c
add support for PR URL
aduh95 a1b1974
check if local HEAD is in sync with release proposal
aduh95 6db9959
Use existing `tryResetBranch` instead of custom git command
aduh95 3cc80b1
auto fix node_version conflicts
aduh95 04b4d4d
add `--dryRun` mode to simplify testing
aduh95 70294cf
fix conflicts making the process crash
aduh95 549ac8e
fix bug when checking modified files
aduh95 4bd64c9
do not hard code default branch name
aduh95 1104f09
fix type
aduh95 5b91899
add `--gpgSign`/`-S` option
aduh95 575196d
fixup! add `--gpgSign`/`-S` option
aduh95 7ed9d06
better handling of releaser not on the team
aduh95 66fdab5
add `gh release create` note
aduh95 79d3789
Fix `undefined` in spinner text
aduh95 d65fd6a
fixup! add `gh release create` note
aduh95 7c1dfbe
make `--dryRun` more useful
aduh95 d9d97cb
fix "release date does not match the system date for today" incorrect…
aduh95 8aa8c08
run `cherry-pick --continue`
aduh95 c1aa8cb
use one `git push` command instead of two
aduh95 4e45c8b
Add a more verbose `--dry-run` message
aduh95 3cccce3
fix typo
aduh95 5ccb474
`--dry-run` -> `--run`
aduh95 0196904
Fix `gh release create` command suggestion
aduh95 423aba8
Merge branch 'main' into git-node-release-promote
aduh95 a9512d0
fetch default branch name from GitHub API
aduh95 37ffe70
add spinner when fetching the proposal
aduh95 c3fb51e
fixup! fetch default branch name from GitHub API
aduh95 55e4a79
allow reusing existing tag as long as it points to the correct commit
aduh95 e78b1c7
Merge branch 'main' into git-node-release-promote
aduh95 94e38df
fix alphabetical order
aduh95 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
lint
- Loading branch information
commit 15c03357351377f73781333cd8663646ae4389ea
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.