Skip to content

docs: update maintaining-dependencies.md on major v8 update #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
targos merged 2 commits into from
Jun 7, 2023
Merged

docs: update maintaining-dependencies.md on major v8 update #699

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f176e7
docs: update maintaining-dependencies.md on major update
fasenderos May 31, 2023
d4e53e5
docs: move maintaining dependencies task
fasenderos Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
docs: update maintaining-dependencies.md on major update
  • Loading branch information
@fasenderos
fasenderos committed May 31, 2023
commit 2f176e7f577447019cf3f0b88ad0376269d8bd69
30 changes: 29 additions & 1 deletion lib/update-v8/updateVersionNumbers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,15 @@ function bumpNodeModule() {
v8Version,
ctx.nodeMajorVersion
);
await updateMaintainingDependenciesMd(ctx.nodeDir, v8Version);
await updateModuleVersion(ctx.nodeDir, newModuleVersion);
await ctx.execGitNode(
'add',
['doc/abi_version_registry.json', 'src/node_version.h']
[
'doc/abi_version_registry.json',
'doc/contributing/maintaining/maintaining-dependencies.md',
'src/node_version.h'
]
);
await ctx.execGitNode(
'commit',
Expand Down Expand Up @@ -80,6 +85,29 @@ async function updateModuleVersion(nodeDir, newVersion) {
await fs.writeFile(path, nodeVersionH);
}

async function updateMaintainingDependenciesMd(nodeDir, v8Version) {
const path = `${nodeDir}/doc/contributing/maintaining/maintaining-dependencies.md`;
let maintainingDependenciesMd = await fs.readFile(path, 'utf8');
const version = v8Version.toString();
const versionNoDots = version.replaceAll('.', '');
// V8 itemlist link
maintainingDependenciesMd = maintainingDependenciesMd.replace(
/\* \[V8.*/,
`* [V8 ${version}][]`
);
// V8 link to section
maintainingDependenciesMd = maintainingDependenciesMd.replace(
/\[v8.*\]: #v8.*/,
`[v8 ${version}]: #v8-${versionNoDots}`
);
// V8 section title
maintainingDependenciesMd = maintainingDependenciesMd.replace(
/### V8.*/,
`### V8 ${version}`
);
await fs.writeFile(path, maintainingDependenciesMd);
}

function getCommitTitle(moduleVersion) {
return `src: update NODE_MODULE_VERSION to ${moduleVersion}`;
}
Expand Down