Skip to content

feat: automate creation of the first LTS release #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
targos merged 4 commits into from
Nov 1, 2020
Merged

feat: automate creation of the first LTS release #514

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f14fcec
feat: automate creation of the first LTS release
richardlau Oct 21, 2020
37b0acb
fixup! feat: automate creation of the first LTS release
richardlau Oct 22, 2020
89c0136
fixup! feat: automate creation of the first LTS release
richardlau Oct 22, 2020
60208b0
fixup! feat: automate creation of the first LTS release
richardlau Oct 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! feat: automate creation of the first LTS release
  • Loading branch information
@richardlau
richardlau committed Oct 22, 2020
commit 89c01363719179c4b85086fa6c5146fd1286a0b4
3 changes: 2 additions & 1 deletion lib/prepare_release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,8 @@ class ReleasePreparation {
async getLTSCodename(version) {
const { cli } = this;
return await cli.prompt(
'Enter the LTS code name for this release line:',
'Enter the LTS code name for this release line\n' +
'(Refs: https://github.com/nodejs/Release/blob/master/CODENAMES.md):',
{ questionType: 'input', noSeparator: true, defaultAnswer: '' }
);
Comment on lines +273 to +278

@targos targos Oct 22, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a link to https://github.com/nodejs/Release/blob/master/CODENAMES.md ?

@richardlau richardlau Oct 22, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a link to https://github.com/nodejs/Release/blob/master/CODENAMES.md ?

Done.

}
Expand Down