Skip to content

feat: output email when syncing team #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
avivkeller wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: output email when syncing team #1098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat: output email when syncing team
  • Loading branch information
@avivkeller
avivkeller committed Jun 20, 2026
commit 2d5808020c817851eca6ac9bea4713c61a9f11e1
2 changes: 1 addition & 1 deletion lib/team_info.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ function byLogin(a, b) {

function getContact({ login, url, name, email }) {
if (!name) return `* [@${login}](${url})`;
return `* [@${login}](${url}) - ${name}`;
return `* [@${login}](${url}) - ${name}${email ? ` <${email}>` : ''}`;
}

function key(org, team) {
Expand Down
4 changes: 2 additions & 2 deletions test/fixtures/ncu_team_sync_expected.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<!-- ncu-team-sync.team(nodejs/automation-collaborators) -->

* [@Bar](https://github.com/Bar) - Bar Bar
* [@foo](https://github.com/foo) - Mr. foo
* [@quo](https://github.com/quo) - Ms. Quo
* [@foo](https://github.com/foo) - Mr. foo <foo@example.com>
* [@quo](https://github.com/quo) - Ms. Quo <quo@me.com>

<!-- ncu-team-sync end -->

Expand Down
4 changes: 2 additions & 2 deletions test/fixtures/ncu_team_sync_out.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<!-- ncu-team-sync.team(nodejs/automation-collaborators) -->

* [@Bar](https://github.com/Bar) - Bar Bar
* [@foo](https://github.com/foo) - Mr. foo
* [@quo](https://github.com/quo) - Ms. Quo
* [@foo](https://github.com/foo) - Mr. foo <foo@example.com>
* [@quo](https://github.com/quo) - Ms. Quo <quo@me.com>

<!-- ncu-team-sync end -->

Expand Down
4 changes: 2 additions & 2 deletions test/unit/team_info.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ import { readJSON, readFile, path as getPath } from '../fixtures/index.js';

const collabList =
`* [@Bar](https://github.com/Bar) - Bar Bar
* [@foo](https://github.com/foo) - Mr. foo
* [@quo](https://github.com/quo) - Ms. Quo`;
* [@foo](https://github.com/foo) - Mr. foo <foo@example.com>
* [@quo](https://github.com/quo) - Ms. Quo <quo@me.com>`;

describe('TeamInfo', function() {
let request;
Expand Down
Loading