Skip to content

doc: small fixes in the buffer.md #9795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vsemozhetbyt wants to merge 10 commits into from
Closed

doc: small fixes in the buffer.md #9795

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
df33c79
doc: var => const/let in the buffer.md
vsemozhetbyt Nov 25, 2016
365ad3c
doc: fix a syntax error in the buffer.md
vsemozhetbyt Nov 26, 2016
da92b8e
doc: fix wrong function arguments in the buffer.md
vsemozhetbyt Nov 26, 2016
65abe28
doc: fix copy-paste artifacts in the buffer.md
vsemozhetbyt Nov 26, 2016
625fece
doc: repeat a remark as needed in the buffer.md
vsemozhetbyt Nov 26, 2016
70f9f3b
doc: add a variable declaration in the buffer.md
vsemozhetbyt Nov 26, 2016
a50f3b2
doc: remove a wrong remark in the buffer.md
vsemozhetbyt Nov 26, 2016
41c1a2c
doc: fix examples in buffer.md to avoid confusion
vsemozhetbyt Nov 26, 2016
55449d3
doc: remove an extraneous word in the buffer.md
vsemozhetbyt Nov 27, 2016
8f260ec
doc: fix a wrong note in the buffer.md
vsemozhetbyt Dec 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: fix wrong function arguments in the buffer.md
  • Loading branch information
@vsemozhetbyt
vsemozhetbyt committed Nov 26, 2016
commit da92b8e7a2291e1b1e179faa513c4f546861dda7
4 changes: 2 additions & 2 deletions doc/api/buffer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1264,7 +1264,7 @@ console.log(buf.lastIndexOf('buffer', 4));
const utf16Buffer = Buffer.from('\u039a\u0391\u03a3\u03a3\u0395', 'ucs2');

// Prints: 6
console.log(utf16Buffer.lastIndexOf('\u03a3', null, 'ucs2'));
console.log(utf16Buffer.lastIndexOf('\u03a3', undefined, 'ucs2'));

@silverwind silverwind Dec 3, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both null and undefined are technically not valid arguments. Maybe make a better example?

@vsemozhetbyt vsemozhetbyt Dec 4, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silverwind It is a bit complicated here and I hoped it would be fixed fully when #9801 is addressed. Maybe this could be postponed till that big issue fixed?

@silverwind silverwind Dec 4, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah fine with me.


// Prints: 4
console.log(utf16Buffer.lastIndexOf('\u03a3', -5, 'ucs2'));
Expand Down Expand Up @@ -1446,7 +1446,7 @@ const buf = Buffer.from([0, 5]);
console.log(buf.readInt16BE());

// Prints: 1280
console.log(buf.readInt16LE(1));
console.log(buf.readInt16LE());

// Throws an exception: RangeError: Index out of range
console.log(buf.readInt16LE(1));
Expand Down